added logging to trace scix id collisions#227
Merged
mugdhapolimera merged 1 commit intoadsabs:masterfrom Apr 9, 2026
Merged
Conversation
|
Coverage is 72.424% — mugdhapolimera:scixid-logging into adsabs:master. No base build found for |
tjacovich
approved these changes
Apr 8, 2026
Contributor
tjacovich
left a comment
tjacovich
left a comment
There was a problem hiding this comment.
Looks good. Just one question about capturing the original error so the original message doesn't get lost in the event the error turns out not to be an ID collision.
mugdhapolimera
commented
Apr 9, 2026
mugdhapolimera
force-pushed
the
scixid-logging
branch
from
d236b64 to
97e9a26
Compare
tjacovich
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.